Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IndexType #139

Merged
merged 11 commits into from
Jul 5, 2023
Merged

Add IndexType #139

merged 11 commits into from
Jul 5, 2023

Conversation

dpgrote
Copy link
Contributor

@dpgrote dpgrote commented Jun 20, 2023

No description provided.

@ax3l ax3l self-requested a review June 22, 2023 18:39
@ax3l ax3l self-assigned this Jun 22, 2023
@ax3l
Copy link
Member

ax3l commented Jun 22, 2023

Thank you @dpgrote , this is awesome!

Can you please add functionality tests for pytest in tests/ for the new class?

@@ -0,0 +1,78 @@
# -*- coding: utf-8 -*-

import numpy as np

Check notice

Code scanning / CodeQL

Unused import Note test

Import of 'np' is not used.
tests/test_indextype.py Dismissed Show dismissed Hide dismissed
tests/test_indextype.py Dismissed Show dismissed Hide dismissed
tests/test_indextype.py Dismissed Show dismissed Hide dismissed
tests/test_indextype.py Dismissed Show dismissed Hide dismissed
tests/test_indextype.py Dismissed Show dismissed Hide dismissed
tests/test_indextype.py Dismissed Show dismissed Hide dismissed
using namespace amrex;

namespace {
const int check_index(const int i)

Check warning

Code scanning / CodeQL

Constant return type Warning

The 'const' modifier has no effect on a return type and can be removed.
tests/test_indextype.py Fixed Show fixed Hide fixed
tests/test_indextype.py Fixed Show fixed Hide fixed
tests/test_indextype.py Fixed Show fixed Hide fixed
tests/test_indextype.py Fixed Show fixed Hide fixed
tests/test_indextype.py Fixed Show fixed Hide fixed
tests/test_indextype.py Fixed Show fixed Hide fixed
Copy link
Member

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks a lot!

@ax3l ax3l merged commit 0354504 into AMReX-Codes:development Jul 5, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants